extensions/renderer/injection_host.h - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/injection_host.h

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix extension page content scripts Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/extension_injection_host.h ('K') | « extensions/renderer/extension_injection_host.cc ('k') | extensions/renderer/programmatic_script_injector.h » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/injection_host.h

diff --git a/extensions/renderer/injection_host.h b/extensions/renderer/injection_host.h

index 4dcb225f2aedd8a644c1203a61f22e91c1fad91c..d7f4b7e9935bfbefb6a6493d923866333ef7d3a4 100644

--- a/extensions/renderer/injection_host.h

+++ b/extensions/renderer/injection_host.h

@@ -9,6 +9,10 @@

#include "extensions/common/permissions/permissions_data.h"

#include "url/gurl.h"

+namespace blink {

+class WebFrame;

// An interface for all kinds of hosts who own user scripts.

class InjectionHost {

public:

@@ -26,7 +30,7 @@ class InjectionHost {

// Returns true if the script should execute.

virtual extensions::PermissionsData::AccessType CanExecuteOnFrame(

const GURL& document_url,

- const GURL& top_frame_url,

+ blink::WebFrame* web_frame,

int tab_id,

bool is_declarative) const = 0;