chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix extension page content scripts Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/common/extensions/permissions/permissions_data_unittest.cc » ('j') | extensions/browser/extension_web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

index 893b5d4a4b20a6356aa524720a08bdb44489bd17..8cc795b68737990ee2d2227634afd6f6e22e4511 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

@@ -37,8 +37,7 @@ TEST_F(ChromePermissionManifestTest, ChromeURLPermissionAllowedWithFlag) {

EXPECT_EQ("", error);

const GURL newtab_url(chrome::kChromeUINewTabURL);

EXPECT_TRUE(extension->permissions_data()->CanAccessPage(

- extension.get(), newtab_url, newtab_url, 0, -1, &error))

- << error;

+ extension.get(), newtab_url, 0, -1, &error)) << error;

}

TEST_F(ChromePermissionManifestTest,