extensions/browser/extension_web_contents_observer.h - Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_web_contents_observer.h

Issue 1150683007: [Extensions] Use document url (not top url) for tab-specific permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix extension page content scripts Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc ('k') | extensions/browser/extension_web_contents_observer.cc » ('j') | extensions/browser/extension_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_web_contents_observer.h

diff --git a/extensions/browser/extension_web_contents_observer.h b/extensions/browser/extension_web_contents_observer.h

index d36d782555131e8c5ae296654f6063a3b5d8a342..a82eff4356b63ca3b326b733965e87a92b648f4f 100644

--- a/extensions/browser/extension_web_contents_observer.h

+++ b/extensions/browser/extension_web_contents_observer.h

@@ -69,6 +69,8 @@ class ExtensionWebContentsObserver : public content::WebContentsObserver {

// The BrowserContext associated with the WebContents being observed.

content::BrowserContext* browser_context_;

+ std::string extension_id_;

not at google - send to devlin 2015/06/03 20:15:44 Seem unnecessary given ProcessManager, plus you ha

Devlin 2015/06/03 20:28:47 Totally accidental. Removed.

DISALLOW_COPY_AND_ASSIGN(ExtensionWebContentsObserver);

};