Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1150683002: Remove obsolete JSFunction::IsOptimizable predicate. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-15
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete JSFunction::IsOptimizable predicate. This just delegates to SharedFunctionInfo::optimization_disabled and was primarily used for assertions. Removing it due to misleading name because already optimized functions reported being "non-optimizable". R=titzer@chromium.org Committed: https://crrev.com/181d7b85977eb752b19e1de902093783e31330ef Cr-Commit-Position: refs/heads/master@{#28551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime-profiler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-20 17:25:46 UTC) #1
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-21 11:28:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150683002/1
5 years, 7 months ago (2015-05-21 13:04:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 13:05:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/181d7b85977eb752b19e1de902093783e31330ef Cr-Commit-Position: refs/heads/master@{#28551}
5 years, 7 months ago (2015-05-21 13:06:04 UTC) #7
Michael Starzinger
5 years, 7 months ago (2015-05-21 13:34:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1148973005/ by mstarzinger@chromium.org.

The reason for reverting is: Causes assertions to fire when serializing
optimized code..

Powered by Google App Engine
This is Rietveld 408576698