Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: src/objects-inl.h

Issue 1150683002: Remove obsolete JSFunction::IsOptimizable predicate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-15
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5988 matching lines...) Expand 10 before | Expand all | Expand 10 after
5999 return shared()->internal_formal_parameter_count() != 5999 return shared()->internal_formal_parameter_count() !=
6000 SharedFunctionInfo::kDontAdaptArgumentsSentinel; 6000 SharedFunctionInfo::kDontAdaptArgumentsSentinel;
6001 } 6001 }
6002 6002
6003 6003
6004 bool JSFunction::IsOptimized() { 6004 bool JSFunction::IsOptimized() {
6005 return code()->kind() == Code::OPTIMIZED_FUNCTION; 6005 return code()->kind() == Code::OPTIMIZED_FUNCTION;
6006 } 6006 }
6007 6007
6008 6008
6009 bool JSFunction::IsOptimizable() {
6010 return code()->kind() == Code::FUNCTION && !shared()->optimization_disabled();
6011 }
6012
6013
6014 bool JSFunction::IsMarkedForOptimization() { 6009 bool JSFunction::IsMarkedForOptimization() {
6015 return code() == GetIsolate()->builtins()->builtin( 6010 return code() == GetIsolate()->builtins()->builtin(
6016 Builtins::kCompileOptimized); 6011 Builtins::kCompileOptimized);
6017 } 6012 }
6018 6013
6019 6014
6020 bool JSFunction::IsMarkedForConcurrentOptimization() { 6015 bool JSFunction::IsMarkedForConcurrentOptimization() {
6021 return code() == GetIsolate()->builtins()->builtin( 6016 return code() == GetIsolate()->builtins()->builtin(
6022 Builtins::kCompileOptimizedConcurrent); 6017 Builtins::kCompileOptimizedConcurrent);
6023 } 6018 }
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
7615 #undef READ_SHORT_FIELD 7610 #undef READ_SHORT_FIELD
7616 #undef WRITE_SHORT_FIELD 7611 #undef WRITE_SHORT_FIELD
7617 #undef READ_BYTE_FIELD 7612 #undef READ_BYTE_FIELD
7618 #undef WRITE_BYTE_FIELD 7613 #undef WRITE_BYTE_FIELD
7619 #undef NOBARRIER_READ_BYTE_FIELD 7614 #undef NOBARRIER_READ_BYTE_FIELD
7620 #undef NOBARRIER_WRITE_BYTE_FIELD 7615 #undef NOBARRIER_WRITE_BYTE_FIELD
7621 7616
7622 } } // namespace v8::internal 7617 } } // namespace v8::internal
7623 7618
7624 #endif // V8_OBJECTS_INL_H_ 7619 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698