webview: Initialize synchronous compositor after first activation.

webview: Initialize synchronous compositor after first activation.

Drawing before the first activation produces no results but can cause
cc DCHECKs to fail. To prevent this SynchronousCompositorImpl doesn't
register with it's client until the first activation.

BUG=492815
Committed: https://crrev.com/0e3d721470add955c056e3051614f58c7220e85b
Cr-Commit-Position: refs/heads/master@{#332334}

[sunnyps, 2015-05-29 23:09:58]

sunnyps@chromium.org changed reviewers:
+ boliu@chromium.org

[sunnyps, 2015-05-29 23:09:58]

PTAL

[boliu, 2015-05-29 23:21:12]

https://codereview.chromium.org/1150423003/diff/1/content/browser/android/in_...
File content/browser/android/in_process/synchronous_compositor_impl.cc (right):

https://codereview.chromium.org/1150423003/diff/1/content/browser/android/in_...
content/browser/android/in_process/synchronous_compositor_impl.cc:159:
compositor_client_->DidDestroyCompositor(this);
Every single compositor_client_ call needs to be guarded by has_initialized_
now. DidInitializeCompositor must be the first call into compositor_client_ or
bad things may happen. Seems large change, but this really is the right place to
handle this.

Not too long ago, there were null checks. You can do the same thing as the old
null behavior when has_initialized_ is false:
https://codereview.chromium.org/1127943002/

[boliu, 2015-05-29 23:22:32]

https://codereview.chromium.org/1150423003/diff/1/content/browser/android/in_...
File content/browser/android/in_process/synchronous_compositor_impl.h (right):

https://codereview.chromium.org/1150423003/diff/1/content/browser/android/in_...
content/browser/android/in_process/synchronous_compositor_impl.h:115: bool
has_initialized_;
output_surface_ready_? And leave a comment explanation what this is for here

[sunnyps, 2015-05-30 00:19:39]

PTAL

Previous approach was causing issues with the GC tests - DidDestroyCompositor
was being called before DidInitializeCompositor.

I'm trying a new approach here - if the output surface isn't ready we don't draw
in both HW and SW mode. Output surface is marked ready on first activation.

[sunnyps, 2015-05-30 00:59:17]

PTAL

[boliu, 2015-05-30 01:06:29]

lgtm

https://codereview.chromium.org/1150423003/diff/40001/content/browser/android...
File content/browser/android/in_process/synchronous_compositor_impl.cc (right):

https://codereview.chromium.org/1150423003/diff/40001/content/browser/android...
content/browser/android/in_process/synchronous_compositor_impl.cc:374: if
(registered_with_client_)
style: Need braces for if statements with multi-line body

[mithro-old, 2015-06-01 03:29:20]

On 2015/05/30 01:06:29, boliu wrote:
> lgtm
> 
>
https://codereview.chromium.org/1150423003/diff/40001/content/browser/android...
> File content/browser/android/in_process/synchronous_compositor_impl.cc
(right):
> 
>
https://codereview.chromium.org/1150423003/diff/40001/content/browser/android...
> content/browser/android/in_process/synchronous_compositor_impl.cc:374: if
> (registered_with_client_)
> style: Need braces for if statements with multi-line body

LGTM.

We really should have a test for this specific issue somewhere rather than
relying on other tests to become flaky, that can wait for another CL though.

[sunnyps, 2015-06-01 18:49:17]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-06-01 18:49:17]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
mithro@mithis.com
Link to the patchset: https://codereview.chromium.org/1150423003/#ps60001
(title: "braces")

[commit-bot: I haz the power, 2015-06-01 18:51:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150423003/60001

[commit-bot: I haz the power, 2015-06-01 21:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 21:04:35]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[sunnyps, 2015-06-02 01:36:40]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[sunnyps, 2015-06-02 01:36:40]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
mithro@mithis.com
Link to the patchset: https://codereview.chromium.org/1150423003/#ps80001
(title: "fix broken tests")

[sunnyps, 2015-06-02 01:38:02]

Turned out that setting the delegate for input handler causes
UpdateRootLayerState to be called immediately so we should do that after
initializing with the client.

Some code has been simplified + some style changes as well.

PTAL.

[commit-bot: I haz the power, 2015-06-02 01:39:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150423003/80001

[carpediemishere_gmail.com, 2015-06-02 01:41:44]

how do i unsubscribe from this list?

On Mon, Jun 1, 2015 at 9:39 PM, 'commit-bot: I haz the power' via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1150423003/80001
>
>
>
> https://codereview.chromium.org/1150423003/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[boliu, 2015-06-02 01:47:42]

boliu@chromium.org changed reviewers:
- carpediemishere@gmail.com

[boliu, 2015-06-02 01:47:42]

lgtm

[commit-bot: I haz the power, 2015-06-02 02:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 02:38:23]

Dry run: This issue passed the CQ dry run.

[sunnyps, 2015-06-02 03:04:27]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2015-06-02 03:04:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150423003/80001

[commit-bot: I haz the power, 2015-06-02 03:09:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-02 03:10:33]

Patchset 5 (id:??) landed as
https://crrev.com/0e3d721470add955c056e3051614f58c7220e85b
Cr-Commit-Position: refs/heads/master@{#332334}