content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc - Issue 1150423003: webview: Initialize synchronous compositor after first activation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc

Issue 1150423003: webview: Initialize synchronous compositor after first activation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix broken tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java ('k') | content/browser/android/in_process/synchronous_compositor_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc

diff --git a/content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc b/content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc

index 17f1d1a8d2c932e75eb852b5e586294f2d434a2d..fd9513cb89de139d075ee8fe9998eae6a39bde08 100644

--- a/content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc

+++ b/content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc

@@ -38,7 +38,15 @@ void SynchronousCompositorExternalBeginFrameSource::BeginFrame(

void SynchronousCompositorExternalBeginFrameSource::SetCompositor(

SynchronousCompositorImpl* compositor) {

DCHECK(CalledOnValidThread());

+ if (compositor_ == compositor) return;

+ if (compositor_)

+ compositor_->OnNeedsBeginFramesChange(false);

compositor_ = compositor;

+ if (compositor_)

+ compositor_->OnNeedsBeginFramesChange(needs_begin_frames_);

}

void SynchronousCompositorExternalBeginFrameSource::OnNeedsBeginFramesChange(