Issue 1150383003: Don't iterate past the end of the metrics list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1150383003: Don't iterate past the end of the metrics list (Closed)

Created:
5 years, 6 months ago by fs

Modified:
5 years, 6 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't iterate past the end of the metrics list This check was lost in https://codereview.chromium.org/1160623002. In some cases (unpaired surrogates), the metrics list will not cover the full range of characters in the text node. Make sure to terminate the iteration when that happens. BUG=495969, 486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196408

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1 line)			Patch
A	LayoutTests/svg/text/unpaired-surrogate-crash.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/text/unpaired-surrogate-crash-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/layout/svg/LayoutSVGInlineText.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/layout/svg/SVGTextLayoutEngine.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150383003/1

5 years, 6 months ago (2015-06-03 15:21:49 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-03 15:25:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196408

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages