Source/core/layout/svg/LayoutSVGInlineText.h - Issue 1150383003: Don't iterate past the end of the metrics list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/LayoutSVGInlineText.h

Issue 1150383003: Don't iterate past the end of the metrics list (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/svg/LayoutSVGInlineText.h

diff --git a/Source/core/layout/svg/LayoutSVGInlineText.h b/Source/core/layout/svg/LayoutSVGInlineText.h

index 98594511cc37aa203334a8a99ccd3ad40a92fe2a..b0f22264ab509266e1c11beb6c8e1721e56e1c98 100644

--- a/Source/core/layout/svg/LayoutSVGInlineText.h

+++ b/Source/core/layout/svg/LayoutSVGInlineText.h

@@ -106,6 +106,7 @@ public:

const Vector<SVGTextMetrics>& metricsList() const { return m_textLayoutObject->layoutAttributes()->textMetricsValues(); }

unsigned metricsListOffset() const { return m_metricsListOffset; }

unsigned characterOffset() const { return m_characterOffset; }

+ bool isAtEnd() const { return m_metricsListOffset == metricsList().size(); }

private:

void reset(const LayoutSVGInlineText* textLayoutObject)