Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1150263003: Stop leaking the TracingController's BroadcastReciever (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix return type #

Patch Set 3 : Add missing call to super.onStop() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M sky/shell/android/org/domokit/sky/shell/SkyActivity.java View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/TracingController.java View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 6 months ago (2015-06-05 21:08:19 UTC) #1
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-05 21:08:58 UTC) #2
eseidel
5 years, 6 months ago (2015-06-05 21:09:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0fd2d8b1315b818dbb6cb86b9138d45338743e65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698