Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: sky/shell/android/org/domokit/sky/shell/SkyActivity.java

Issue 1150263003: Stop leaking the TracingController's BroadcastReciever (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add missing call to super.onStop() Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/shell/android/org/domokit/sky/shell/TracingController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/shell/android/org/domokit/sky/shell/SkyActivity.java
diff --git a/sky/shell/android/org/domokit/sky/shell/SkyActivity.java b/sky/shell/android/org/domokit/sky/shell/SkyActivity.java
index 101c282665a69eac5f649a47fee7c7af9ad19e23..47480222d631d8d1010aa41565d32158ee3ef8fc 100644
--- a/sky/shell/android/org/domokit/sky/shell/SkyActivity.java
+++ b/sky/shell/android/org/domokit/sky/shell/SkyActivity.java
@@ -38,6 +38,16 @@ public class SkyActivity extends Activity {
mTracingController = new TracingController(this);
}
+ /**
+ * @see android.app.Activity#onStop()
+ */
+ @Override
+ protected void onStop() {
+ // Do we need to shut down Sky too?
+ mTracingController.stop();
+ super.onStop();
+ }
+
public void loadUrl(String url) {
mView.loadUrl(url);
}
« no previous file with comments | « no previous file | sky/shell/android/org/domokit/sky/shell/TracingController.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698