runtime/vm/cpuinfo_macos.cc - Issue 1150173004: - Make sure to properly check for errors from sysctlbyname.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cpuinfo_macos.cc

Issue 1150173004: - Make sure to properly check for errors from sysctlbyname. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/cpuinfo_macos.cc

diff --git a/runtime/vm/cpuinfo_macos.cc b/runtime/vm/cpuinfo_macos.cc

index 6300d7c7f7298a130c562ffd6d59ba78198ccd4c..63523914ddf4c2bd581ebe4e2edb897b2e3c46cd 100644

--- a/runtime/vm/cpuinfo_macos.cc

+++ b/runtime/vm/cpuinfo_macos.cc

@@ -85,7 +85,7 @@ bool CpuInfo::HasField(const char* field) {

ASSERT(method_ != kCpuInfoDefault);

ASSERT(field != NULL);

int ret = sysctlbyname(field, NULL, NULL, NULL, 0);

- return (ret != ENOENT);

+ return (ret == 0);

}

} // namespace dart

« no previous file with comments | « no previous file | no next file » | no next file with comments »