runtime/vm/cpuinfo_macos.cc - Issue 1150173004: - Make sure to properly check for errors from sysctlbyname.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/cpuinfo_macos.cc

Issue 1150173004: - Make sure to properly check for errors from sysctlbyname. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/globals.h"	5 #include "vm/globals.h"

6 #if defined(TARGET_OS_MACOS)	6 #if defined(TARGET_OS_MACOS)

7	7

8 #include "vm/cpuinfo.h"	8 #include "vm/cpuinfo.h"

9	9

10 #include <errno.h> // NOLINT	10 #include <errno.h> // NOLINT

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 const char* CpuInfo::ExtractField(CpuInfoIndices idx) {	78 const char* CpuInfo::ExtractField(CpuInfoIndices idx) {

79 ASSERT(method_ != kCpuInfoDefault);	79 ASSERT(method_ != kCpuInfoDefault);

80 return ExtractFieldByString(FieldName(idx));	80 return ExtractFieldByString(FieldName(idx));

81 }	81 }

82	82

83	83

84 bool CpuInfo::HasField(const char* field) {	84 bool CpuInfo::HasField(const char* field) {

85 ASSERT(method_ != kCpuInfoDefault);	85 ASSERT(method_ != kCpuInfoDefault);

86 ASSERT(field != NULL);	86 ASSERT(field != NULL);

87 int ret = sysctlbyname(field, NULL, NULL, NULL, 0);	87 int ret = sysctlbyname(field, NULL, NULL, NULL, 0);

88 return (ret != ENOENT);	88 return (ret == 0);

89 }	89 }

90	90

91 } // namespace dart	91 } // namespace dart

92	92

93 #endif // defined(TARGET_OS_MACOS)	93 #endif // defined(TARGET_OS_MACOS)

OLD	NEW