Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1150083006: [turbofan] Tester improvements; use CSignature and simplify ReturnValueTraits. (Closed)

Created:
5 years, 6 months ago by titzer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Tester improvements; use CSignature and simplify ReturnValueTraits. R=bmeurer@chromium.org,mstarzinger@chromium.org BUG= Committed: https://crrev.com/1a23f031e8d8a81eec670282539a2eae9868e307 Cr-Commit-Position: refs/heads/master@{#28733}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -170 lines) Patch
M test/cctest/compiler/c-signature.h View 2 chunks +60 lines, -60 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 1 2 7 chunks +62 lines, -95 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +4 lines, -6 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years, 6 months ago (2015-06-01 12:33:32 UTC) #1
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-01 14:24:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150083006/40001
5 years, 6 months ago (2015-06-01 15:53:27 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-01 15:54:59 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 15:55:11 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a23f031e8d8a81eec670282539a2eae9868e307
Cr-Commit-Position: refs/heads/master@{#28733}

Powered by Google App Engine
This is Rietveld 408576698