Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1150033006: Add support for Mac vs. Linux sky_server builds (Closed)

Created:
5 years, 7 months ago by eseidel
Modified:
5 years, 7 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add support for Mac vs. Linux sky_server builds I also made sky_server get pulled down via DEPS since thats how all the rest of our google storage-based binaries work. R=jamesr@chromium.org, jackson@google.com TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/22feaa0e7f171e5edbf133959acf5a65b16ca5b6

Patch Set 1 #

Patch Set 2 : Remove download_sky_server #

Patch Set 3 : Add missing sha1 file #

Total comments: 4

Patch Set 4 : Update per jamesr's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -40 lines) Patch
M DEPS View 1 chunk +23 lines, -0 lines 0 comments Download
M sky/HACKING.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/download_sky_server View 1 1 chunk +0 lines, -24 lines 0 comments Download
M sky/tools/skygo/README View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A sky/tools/skygo/linux64/sky_server.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A sky/tools/skygo/mac/sky_server.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
D sky/tools/skygo/sky_server.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/skypy/skyserver.py View 3 chunks +13 lines, -4 lines 0 comments Download
M sky/tools/test_perf View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
eseidel
5 years, 7 months ago (2015-05-26 21:14:18 UTC) #1
eseidel
Maybe jamesr wants to see this. This fixes skydb to be happy on mac w/o ...
5 years, 7 months ago (2015-05-26 21:15:06 UTC) #3
jamesr
How is this different from https://codereview.chromium.org/1132793004/ ?
5 years, 7 months ago (2015-05-26 23:32:04 UTC) #4
eseidel
I am now :sadpanda:. I did not know someone had already written that. :(
5 years, 7 months ago (2015-05-26 23:32:55 UTC) #5
eseidel
I think this one is simpler though. It makes us use DEPS instead of our ...
5 years, 7 months ago (2015-05-26 23:33:54 UTC) #7
jamesr
https://codereview.chromium.org/1150033006/diff/10010/sky/HACKING.md File sky/HACKING.md (right): https://codereview.chromium.org/1150033006/diff/10010/sky/HACKING.md#newcode33 sky/HACKING.md:33: * ``sky/tools/skygo/linux/sky_server -t Debug . 8000`` the "linux" but ...
5 years, 7 months ago (2015-05-26 23:36:03 UTC) #8
eseidel
https://codereview.chromium.org/1150033006/diff/10010/sky/HACKING.md File sky/HACKING.md (right): https://codereview.chromium.org/1150033006/diff/10010/sky/HACKING.md#newcode33 sky/HACKING.md:33: * ``sky/tools/skygo/linux/sky_server -t Debug . 8000`` On 2015/05/26 at ...
5 years, 7 months ago (2015-05-26 23:44:01 UTC) #9
jamesr
lgtm On 2015/05/26 23:44:01, eseidel wrote: > https://codereview.chromium.org/1150033006/diff/10010/sky/tools/skygo/linux64/sky_server.sha1 > File sky/tools/skygo/linux64/sky_server.sha1 (right): > > https://codereview.chromium.org/1150033006/diff/10010/sky/tools/skygo/linux64/sky_server.sha1#newcode1 ...
5 years, 7 months ago (2015-05-26 23:52:49 UTC) #10
eseidel
5 years, 7 months ago (2015-05-27 17:42:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:50001) manually as
22feaa0e7f171e5edbf133959acf5a65b16ca5b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698