Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: sky/tools/test_perf

Issue 1150033006: Add support for Mac vs. Linux sky_server builds (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Update per jamesr's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/skypy/skyserver.py ('k') | sky/tools/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/test_perf
diff --git a/sky/tools/test_perf b/sky/tools/test_perf
index 8b61767fe3f76864f2b8b491d91bff41fee8b4e4..efd5a6560bfb1261e8d07d133a2ce93147f44cf1 100755
--- a/sky/tools/test_perf
+++ b/sky/tools/test_perf
@@ -10,6 +10,7 @@ import os
import re
import requests
import skypy.configuration as configuration
+import skypy.skyserver
import subprocess
@@ -69,10 +70,9 @@ class PerfHarness(object):
self.args = args
def _start_server(self):
- subprocess.call(os.path.join(self.paths.sky_tools_directory,
- 'download_sky_server'))
+ # TODO(eseidel): Shouldn't this just use skyserver.py?
return subprocess.Popen([
- os.path.join(self.paths.src_root, 'out', 'downloads', 'sky_server'),
+ SkyServer.sky_server_path(),
self.paths.src_root,
str(HTTP_PORT),
'-t', self.args.configuration
« no previous file with comments | « sky/tools/skypy/skyserver.py ('k') | sky/tools/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698