Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1149983008: Change return type of PrintPage (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
pdr., raymes, Charlie Reis, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change return type of PrintPage PrintPage should not return a bool parameter. The return type has been changed to void. To keep it compatible with the blink code, old function has been kept. R=pdr BUG=496765 Committed: https://crrev.com/7095383c395df8c09df779b89bbb86aa69814c3c Cr-Commit-Position: refs/heads/master@{#333715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Habib Virji
This change will involve a total set of five patches. This is patch 1 from ...
5 years, 6 months ago (2015-06-08 17:15:54 UTC) #1
pdr.
I think this plan looks good. +cc piman and creis, could you review this? I ...
5 years, 6 months ago (2015-06-09 20:27:54 UTC) #3
piman
LGTM, +raymes FYI
5 years, 6 months ago (2015-06-09 23:25:58 UTC) #5
Charlie Reis
LGTM
5 years, 6 months ago (2015-06-09 23:56:59 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149983008/1
5 years, 6 months ago (2015-06-10 09:23:22 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 10:08:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149983008/1
5 years, 6 months ago (2015-06-10 10:36:12 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 10:39:42 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 10:40:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7095383c395df8c09df779b89bbb86aa69814c3c
Cr-Commit-Position: refs/heads/master@{#333715}

Powered by Google App Engine
This is Rietveld 408576698