content/renderer/pepper/pepper_plugin_instance_impl.h - Issue 1149983008: Change return type of PrintPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 1149983008: Change return type of PrintPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.h

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h

index cb0f5ea80ab12d3494e487a4dc509de7558ff8f2..bab9c0bf4fe707817437d2fa9cbc9a0ed48445b3 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.h

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h

@@ -255,7 +255,7 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

bool SupportsPrintInterface();

bool IsPrintScalingDisabled();

int PrintBegin(const blink::WebPrintParams& print_params);

- bool PrintPage(int page_number, blink::WebCanvas* canvas);

+ void PrintPage(int page_number, blink::WebCanvas* canvas);

void PrintEnd();

bool GetPrintPresetOptionsFromDocument(

blink::WebPrintPresetOptions* preset_options);

@@ -644,7 +644,7 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

void UpdateLayer(bool device_changed);

// Internal helper function for PrintPage().

- bool PrintPageHelper(PP_PrintPageNumberRange_Dev* page_ranges,

+ void PrintPageHelper(PP_PrintPageNumberRange_Dev* page_ranges,

int num_ranges,

blink::WebCanvas* canvas);

« no previous file with comments | « no previous file | content/renderer/pepper/pepper_plugin_instance_impl.cc » ('j') | no next file with comments »