Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149943003: Oilpan: Rename weak callback related methods (Closed)

Created:
5 years, 7 months ago by haraken
Modified:
5 years, 7 months ago
Reviewers:
oilpan-reviews, keishi, sof
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Rename weak callback related methods Currently methods for global weak processings and methods for thread-local weak processings have confusing names. For example, Heap::pushWeakPointerCallback pushes weak callbacks for thread-local weak processings whereas Heap::popAndInvokeWeakPointerCallback pops weak callbacks for global weak processings. This CL renames those things to make what is global and what is thread-local clearer. BUG=475801 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195779

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M Source/platform/heap/Heap.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 1 5 chunks +12 lines, -12 lines 0 comments Download
M Source/platform/heap/HeapAllocator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/heap/MarkingVisitor.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/MarkingVisitorImpl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/heap/Visitor.h View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
PTAL A simple CL.
5 years, 7 months ago (2015-05-21 01:31:40 UTC) #2
sof
https://codereview.chromium.org/1149943003/diff/1/Source/platform/heap/Heap.h File Source/platform/heap/Heap.h (right): https://codereview.chromium.org/1149943003/diff/1/Source/platform/heap/Heap.h#newcode862 Source/platform/heap/Heap.h:862: static void pushThreadLocalWeakCallback(void* closure, void* containerObject, WeakPointerCallback); Wouldn't it ...
5 years, 7 months ago (2015-05-22 09:07:48 UTC) #4
haraken
https://codereview.chromium.org/1149943003/diff/1/Source/platform/heap/Heap.h File Source/platform/heap/Heap.h (right): https://codereview.chromium.org/1149943003/diff/1/Source/platform/heap/Heap.h#newcode862 Source/platform/heap/Heap.h:862: static void pushThreadLocalWeakCallback(void* closure, void* containerObject, WeakPointerCallback); On 2015/05/22 ...
5 years, 7 months ago (2015-05-22 10:07:08 UTC) #5
sof
lgtm
5 years, 7 months ago (2015-05-22 10:11:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149943003/20001
5 years, 7 months ago (2015-05-22 10:18:58 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 11:43:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195779

Powered by Google App Engine
This is Rietveld 408576698