Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1149913008: Compute the linkMatchType inside the CSSSelectorParser. (Closed)

Created:
5 years, 6 months ago by esprehn
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Compute the linkMatchType inside the CSSSelectorParser. Store the linkMatchType on the first CSSSelector in each CSSSelectorList instead of computing it every time we build the RuleSets. R=timloh@chromium.org BUG=585651

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do it inside consumeComplexSelector. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M Source/core/css/CSSSelector.h View 5 chunks +11 lines, -4 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M Source/core/css/RuleSet.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
esprehn
5 years, 6 months ago (2015-06-02 03:22:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149913008/1
5 years, 6 months ago (2015-06-02 03:54:20 UTC) #4
Timothy Loh
lgtm https://codereview.chromium.org/1149913008/diff/1/Source/core/css/parser/CSSSelectorParser.cpp File Source/core/css/parser/CSSSelectorParser.cpp (right): https://codereview.chromium.org/1149913008/diff/1/Source/core/css/parser/CSSSelectorParser.cpp#newcode94 Source/core/css/parser/CSSSelectorParser.cpp:94: selector->updateLinkMatchType(); Probably better to be in consumeComplexSelector?
5 years, 6 months ago (2015-06-02 04:20:59 UTC) #5
esprehn
On 2015/06/02 at 04:20:59, timloh wrote: > lgtm > > https://codereview.chromium.org/1149913008/diff/1/Source/core/css/parser/CSSSelectorParser.cpp > File Source/core/css/parser/CSSSelectorParser.cpp (right): ...
5 years, 6 months ago (2015-06-02 05:07:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149913008/20001
5 years, 6 months ago (2015-06-02 05:08:11 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 06:50:55 UTC) #11
Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

Powered by Google App Engine
This is Rietveld 408576698