Issue 1149913004: Merge to M44: "Fix a division by zero when multiplying 0 * y with SafeNumerics."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1149913004: Merge to M44: "Fix a division by zero when multiplying 0 * y with SafeNumerics." (Closed)

Created:
5 years, 7 months ago by DaleCurtis

Modified:
5 years, 7 months ago

Reviewers:
jschuh, eroman

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge to M44: "Fix a division by zero when multiplying 0 * y with SafeNumerics." BUG=488302 TBR=eroman,jschuh Review URL: https://codereview.chromium.org/1142783002 Cr-Commit-Position: refs/heads/master@{#330357} (cherry picked from commit 0397125f4b28ef43a26920d1e9c4db55d0703f70)

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	base/numerics/safe_math_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	base/numerics/safe_numerics_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

DaleCurtis

Committed patchset #1 (id:1) to pending queue manually as 8a0307480536f1fda658480766896c8fab06c2c4 (presubmit successful).

5 years, 7 months ago (2015-05-21 01:28:46 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages