Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1142783002: Fix a division by zero when multiplying 0 * y with SafeNumerics. (Closed)

Created:
5 years, 7 months ago by eroman
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez, jschuh
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a division by zero when multiplying 0 * y with SafeNumerics. BUG=488302 Committed: https://crrev.com/0397125f4b28ef43a26920d1e9c4db55d0703f70 Cr-Commit-Position: refs/heads/master@{#330357}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/numerics/safe_math_impl.h View 1 chunk +2 lines, -2 lines 1 comment Download
M base/numerics/safe_numerics_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eroman
(I only need one of Justin or Tom to review; not sure if Justin is ...
5 years, 7 months ago (2015-05-18 00:26:40 UTC) #2
jschuh
lgtm
5 years, 7 months ago (2015-05-18 14:26:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142783002/1
5 years, 7 months ago (2015-05-18 14:27:09 UTC) #5
jschuh
https://codereview.chromium.org/1142783002/diff/1/base/numerics/safe_math_impl.h File base/numerics/safe_math_impl.h (left): https://codereview.chromium.org/1142783002/diff/1/base/numerics/safe_math_impl.h#oldcode180 base/numerics/safe_math_impl.h:180: if (!(x || y)) { fwiw, I think I ...
5 years, 7 months ago (2015-05-18 14:28:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 14:44:43 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 14:45:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0397125f4b28ef43a26920d1e9c4db55d0703f70
Cr-Commit-Position: refs/heads/master@{#330357}

Powered by Google App Engine
This is Rietveld 408576698