Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1149883003: Revert of Add tests to ensure no RFH/RVH objects leak on cross-process navigation (Closed)

Created:
5 years, 7 months ago by Steven Holte
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add tests to ensure no RFH/RVH objects leak on cross-process navigation (patchset #2 id:20001 of https://codereview.chromium.org/1145073004/) Reason for revert: Still causes failures, on both Mac and Win8 Aura https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/2165/steps/content_browsertests%20on%20Mac-10.9/logs/RenderFrameHostManagerTest.CleanupOnCrossProcessNavigation Original issue's description: > Add tests to ensure no RFH/RVH objects leak on cross-process navigation > > These tests were written as part of https://codereview.chromium.org/1150793002/ > which failed on Win8 Aura. Splitting only the test into a separate CL > so it can be committed independently. > > BUG=357747 > > Committed: https://crrev.com/30663b189dafe37e6dd94f73a1d88d9efe8fe787 > Cr-Commit-Position: refs/heads/master@{#331138} TBR=creis@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=357747 Committed: https://crrev.com/13ab9e08366bd255c00f2a5b23a9e75933ec1dd7 Cr-Commit-Position: refs/heads/master@{#331163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -50 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Steven Holte
Created Revert of Add tests to ensure no RFH/RVH objects leak on cross-process navigation
5 years, 7 months ago (2015-05-22 20:02:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149883003/1
5 years, 7 months ago (2015-05-22 20:04:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 20:06:50 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 20:08:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13ab9e08366bd255c00f2a5b23a9e75933ec1dd7
Cr-Commit-Position: refs/heads/master@{#331163}

Powered by Google App Engine
This is Rietveld 408576698