Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1145073004: Add tests to ensure no RFH/RVH objects leak on cross-process navigation (Closed)

Created:
5 years, 7 months ago by nasko
Modified:
5 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests to ensure no RFH/RVH objects leak on cross-process navigation These tests were written as part of https://codereview.chromium.org/1150793002/ which failed on Win8 Aura. Splitting only the test into a separate CL so it can be committed independently. BUG=357747 Committed: https://crrev.com/30663b189dafe37e6dd94f73a1d88d9efe8fe787 Cr-Commit-Position: refs/heads/master@{#331138}

Patch Set 1 #

Patch Set 2 : Include CleanupCrossSiteIframe changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +38 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nasko
Hey Charlie, The ref-counting CL (https://codereview.chromium.org/1150793002/) was reverted due to the leak detection tests failing ...
5 years, 7 months ago (2015-05-22 15:39:22 UTC) #2
Charlie Reis
LGTM
5 years, 7 months ago (2015-05-22 17:28:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145073004/20001
5 years, 7 months ago (2015-05-22 17:28:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 17:44:33 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/30663b189dafe37e6dd94f73a1d88d9efe8fe787 Cr-Commit-Position: refs/heads/master@{#331138}
5 years, 7 months ago (2015-05-22 17:45:31 UTC) #7
Steven Holte
5 years, 7 months ago (2015-05-22 20:02:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1149883003/ by holte@chromium.org.

The reason for reverting is: Still causes failures, on both Mac and Win8 Aura

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/216....

Powered by Google App Engine
This is Rietveld 408576698