Move hash code from hidden string to a private symbol

src/runtime/runtime-symbol.cc

Index: src/runtime/runtime-symbol.cc
diff --git a/src/runtime/runtime-symbol.cc b/src/runtime/runtime-symbol.cc
index e44d15dfce292d16186935d3899f539bb587fb24..1e82ba759b3706ac48c6790330cf03e9398f6604 100644
--- a/src/runtime/runtime-symbol.cc
+++ b/src/runtime/runtime-symbol.cc
@@ -37,8 +37,7 @@ RUNTIME_FUNCTION(Runtime_CreatePrivateOwnSymbol) {
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(Object, name, 0);
   RUNTIME_ASSERT(name->IsString() || name->IsUndefined());
-  Handle<Symbol> symbol = isolate->factory()->NewPrivateOwnSymbol();
-  if (name->IsString()) symbol->set_name(*name);
+  Handle<Symbol> symbol = isolate->factory()->NewPrivateOwnSymbol(name);

[Toon Verwaest, 2015/05/26 09:06:27]

return *isolate-> ...

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

   return *symbol;
 }
 
@@ -57,9 +56,7 @@ RUNTIME_FUNCTION(Runtime_CreateGlobalPrivateOwnSymbol) {
       isolate, symbol, Object::GetPropertyOrElement(privates, name));

[Toon Verwaest, 2015/05/26 09:06:27]

Same here. Given that SetProperty is used below, it wouldn't even work if we'd
look up "name" as an element here, but store it as a named property with
SetProperty (instead of SetElement).

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

   if (!symbol->IsSymbol()) {
     DCHECK(symbol->IsUndefined());
-    symbol = isolate->factory()->NewPrivateSymbol();
-    Handle<Symbol>::cast(symbol)->set_name(*name);
-    Handle<Symbol>::cast(symbol)->set_is_own(true);
+    symbol = isolate->factory()->NewPrivateOwnSymbol(name);
     JSObject::SetProperty(Handle<JSObject>::cast(privates), name, symbol,

[Toon Verwaest, 2015/05/26 09:06:27]

AddProperty

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

                           STRICT).Assert();
   }