Move hash code from hidden string to a private symbol

src/runtime/runtime-symbol.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/arguments.h"
 #include "src/runtime/runtime-utils.h"
 
 namespace v8 {
@@ skipping 19 matching lines @@
   if (name->IsString()) symbol->set_name(*name);
   return *symbol;
 }
 
 
 RUNTIME_FUNCTION(Runtime_CreatePrivateOwnSymbol) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(Object, name, 0);
   RUNTIME_ASSERT(name->IsString() || name->IsUndefined());
-  Handle<Symbol> symbol = isolate->factory()->NewPrivateOwnSymbol();
-  if (name->IsString()) symbol->set_name(*name);
+  Handle<Symbol> symbol = isolate->factory()->NewPrivateOwnSymbol(name);

[Toon Verwaest, 2015/05/26 09:06:27]

return *isolate-> ...

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

   return *symbol;
 }
 
 
 RUNTIME_FUNCTION(Runtime_CreateGlobalPrivateOwnSymbol) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(String, name, 0);
   Handle<JSObject> registry = isolate->GetSymbolRegistry();
   Handle<String> part = isolate->factory()->private_intern_string();
   Handle<Object> privates;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, privates, Object::GetPropertyOrElement(registry, part));

[Toon Verwaest, 2015/05/26 09:06:27]

GetProperty, part is not an element.

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

   Handle<Object> symbol;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, symbol, Object::GetPropertyOrElement(privates, name));

[Toon Verwaest, 2015/05/26 09:06:27]

Same here. Given that SetProperty is used below, it wouldn't even work if we'd
look up "name" as an element here, but store it as a named property with
SetProperty (instead of SetElement).

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

   if (!symbol->IsSymbol()) {
     DCHECK(symbol->IsUndefined());
-    symbol = isolate->factory()->NewPrivateSymbol();
-    Handle<Symbol>::cast(symbol)->set_name(*name);
-    Handle<Symbol>::cast(symbol)->set_is_own(true);
+    symbol = isolate->factory()->NewPrivateOwnSymbol(name);
     JSObject::SetProperty(Handle<JSObject>::cast(privates), name, symbol,

[Toon Verwaest, 2015/05/26 09:06:27]

AddProperty

[Erik Corry Chromium.org, 2015/05/26 09:51:32]

Done.

                           STRICT).Assert();
   }
   return *symbol;
 }
 
 
 RUNTIME_FUNCTION(Runtime_NewSymbolWrapper) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(Symbol, symbol, 0);
@@ skipping 17 matching lines @@
 
 
 RUNTIME_FUNCTION(Runtime_SymbolIsPrivate) {
   SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_CHECKED(Symbol, symbol, 0);
   return isolate->heap()->ToBoolean(symbol->is_private());
 }
 }  // namespace internal
 }  // namespace v8