Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1149823007: Chromecast: adds external_video_surface_java target. (Closed)

Created:
5 years, 6 months ago by gunsch
Modified:
5 years, 6 months ago
Reviewers:
halliwell, alokp
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds external_video_surface_java target. This was split out awhile ago (https://codereview.chromium.org/1123993002), so Android Cast builds have probably been broken @ TOT (runtime) since then. R=halliwell@chromium.org,alokp@chromium.org BUG=None Committed: https://crrev.com/5f7fab58725d10b1ccb26f70c3dfcfc19610f259 Cr-Commit-Position: refs/heads/master@{#332945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 6 months ago (2015-06-04 22:12:16 UTC) #1
halliwell
On 2015/06/04 22:12:16, gunsch wrote: lgtm, we really need to get some basic runtime testing ...
5 years, 6 months ago (2015-06-04 22:21:06 UTC) #2
gunsch
Agreed. That's much more difficult with Android since it requires running on devices, and doubly ...
5 years, 6 months ago (2015-06-04 22:26:07 UTC) #3
alokp
lgtm
5 years, 6 months ago (2015-06-04 22:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149823007/1
5 years, 6 months ago (2015-06-04 22:32:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 22:41:02 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 22:43:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f7fab58725d10b1ccb26f70c3dfcfc19610f259
Cr-Commit-Position: refs/heads/master@{#332945}

Powered by Google App Engine
This is Rietveld 408576698