Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/html_viewer/html_document.cc

Issue 1149793002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: print Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/html_viewer/html_document.cc
diff --git a/components/html_viewer/html_document.cc b/components/html_viewer/html_document.cc
index bb7163763313ae216db3b56b7cddf7e395c96cf5..1358ba7653e2eca949f508e925d246c6a74c5335 100644
--- a/components/html_viewer/html_document.cc
+++ b/components/html_viewer/html_document.cc
@@ -273,6 +273,12 @@ blink::WebFrame* HTMLDocument::createChildFrame(
}
void HTMLDocument::frameDetached(blink::WebFrame* frame) {
+ frameDetached(frame, blink::WebDetachReason::Remove);
dcheng 2015/06/01 21:15:54 Once this is defined inside WebFrameClient, we sho
+}
+
+void HTMLDocument::frameDetached(blink::WebFrame* frame,
+ blink::WebDetachReason reason) {
+ DCHECK(reason == blink::WebDetachReason::Remove);
dcheng 2015/06/01 21:15:54 DCHECK_EQ
if (frame->parent())
frame->parent()->removeChild(frame);

Powered by Google App Engine
This is Rietveld 408576698