Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/render_frame_impl.h

Issue 1149793002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: print Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/html_viewer/html_document.cc ('K') | « components/printing/renderer/print_web_view_helper.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 69a94399c128b474575d3b60692cbcc7152b571f..28e09942bb0817f4a9e1084c07a8379e06eaa044 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -55,6 +55,7 @@ class WebMediaPlayer;
class WebPresentationClient;
class WebPushClient;
class WebSecurityOrigin;
+enum class WebDetachReason;
dcheng 2015/06/01 21:15:54 You shouldn't need to forward declare this, since
struct WebCompositionUnderline;
struct WebContextMenuData;
struct WebCursorInfo;
@@ -366,7 +367,10 @@ class CONTENT_EXPORT RenderFrameImpl
const blink::WebString& name,
blink::WebSandboxFlags sandboxFlags);
virtual void didDisownOpener(blink::WebLocalFrame* frame);
+ // TODO(lfg): Remove this method once the blink patch lands.
virtual void frameDetached(blink::WebFrame* frame);
+ virtual void frameDetached(blink::WebFrame* frame,
+ blink::WebDetachReason reason);
virtual void frameFocused();
virtual void willClose(blink::WebFrame* frame);
virtual void didChangeName(blink::WebLocalFrame* frame,
« components/html_viewer/html_document.cc ('K') | « components/printing/renderer/print_web_view_helper.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698