Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: net/http/http_cache_transaction.cc

Issue 1149763005: Change NetLog::ParametersCallback to return a scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index e39a6c1c63f4f7075168020d74a0dc619dba0a1a..2b96817e56ccb6ecfc17e161b52067e6c9bd13ee 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -182,16 +182,16 @@ void RecordNoStoreHeaderHistogram(int load_flags,
}
}
-base::Value* NetLogAsyncRevalidationInfoCallback(
+scoped_ptr<base::Value> NetLogAsyncRevalidationInfoCallback(
const NetLog::Source& source,
const HttpRequestInfo* request,
NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
- source.AddToEventParameters(dict);
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
+ source.AddToEventParameters(dict.get());
dict->SetString("url", request->url.possibly_invalid_spec());
dict->SetString("method", request->method);
- return dict;
+ return dict.Pass();
}
enum ExternallyConditionalizedType {

Powered by Google App Engine
This is Rietveld 408576698