[Findit] Use step level analysis to exclude flaky test failures.

appengine/findit/waterfall/test/buildbot_test.py

Index: appengine/findit/waterfall/test/buildbot_test.py
diff --git a/appengine/findit/waterfall/test/buildbot_test.py b/appengine/findit/waterfall/test/buildbot_test.py
index 99b8c559c0a42ee3c9fd821394e5d4faf5aee5d1..068507531f2c3d46ef3f2f20b3e5196065612948 100644
--- a/appengine/findit/waterfall/test/buildbot_test.py
+++ b/appengine/findit/waterfall/test/buildbot_test.py
@@ -3,7 +3,10 @@
 # found in the LICENSE file.
 
 from datetime import datetime
+import gzip
 import os
+
+import cloudstorage as gcs
 import unittest

[stgao, 2015/05/27 00:18:21]

unittest is in the standard python library, not a third-party library like gcs.

is gcs used in this module?

[chanli, 2015/05/27 00:32:15]

Done.

 
 from common.retry_http_client import RetryHttpClient
@@ -120,6 +123,19 @@ class BuildBotTest(unittest.TestCase):
         buildbot.CreateStdioLogUrl(
             master_name, builder_name, build_number, step_name))
 
+  def testCreateGtestResultPath(self):
+    master_name = 'a'
+    builder_name = 'Win7 Tests (1)'
+    build_number = 123
+    step_name = '[trigger] abc_tests'
+    expected_stdio_log_url = ('/chrome-gtest-results/buildbot/a/Win7 Tests '
+                              '(1)/123/[trigger] abc_tests.json.gz')
+
+    self.assertEqual(
+        expected_stdio_log_url,
+        buildbot.CreateGtestResultPath(
+            master_name, builder_name, build_number, step_name))
+
   def testGetBuildDataFromArchiveSuccess(self):
     master_name = 'a'
     builder_name = 'b c'