[Findit] Use step level analysis to exclude flaky test failures.

appengine/findit/waterfall/test/buildbot_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
+import gzip
 import os
+
+import cloudstorage as gcs
 import unittest

[stgao, 2015/05/27 00:18:21]

unittest is in the standard python library, not a third-party library like gcs.

is gcs used in this module?

[chanli, 2015/05/27 00:32:15]

Done.

 
 from common.retry_http_client import RetryHttpClient
 from waterfall import buildbot
 
 
 class DummyHttpClient(RetryHttpClient):
 
   def __init__(self, status_code, response_content):
     self.status_code = status_code
     self.response_content = response_content
@@ skipping 95 matching lines @@
     step_name = '[trigger] abc_tests'
     expected_stdio_log_url = ('https://build.chromium.org/p/a/builders/'
                               'Win7%20Tests%20%281%29/builds/123/steps/'
                               '%5Btrigger%5D%20abc_tests/logs/stdio/text')
 
     self.assertEqual(
         expected_stdio_log_url,
         buildbot.CreateStdioLogUrl(
             master_name, builder_name, build_number, step_name))
 
+  def testCreateGtestResultPath(self):
+    master_name = 'a'
+    builder_name = 'Win7 Tests (1)'
+    build_number = 123
+    step_name = '[trigger] abc_tests'
+    expected_stdio_log_url = ('/chrome-gtest-results/buildbot/a/Win7 Tests '
+                              '(1)/123/[trigger] abc_tests.json.gz')
+
+    self.assertEqual(
+        expected_stdio_log_url,
+        buildbot.CreateGtestResultPath(
+            master_name, builder_name, build_number, step_name))
+
   def testGetBuildDataFromArchiveSuccess(self):
     master_name = 'a'
     builder_name = 'b c'
     build_number = 1
     expected_url = ('https://chrome-build-extract.appspot.com/p/a/builders/'
                     'b%20c/builds/1?json=1')
     http_client = DummyHttpClient(200, 'abc')
     data = buildbot.GetBuildDataFromArchive(
         master_name, builder_name, build_number, http_client)
     self.assertEqual(http_client.response_content, data)
@@ skipping 196 matching lines @@
     self.assertEqual(master_name, build_info.master_name)
     self.assertEqual(builder_name, build_info.builder_name)
     self.assertEqual(build_number, build_info.build_number)
     self.assertEqual(expected_build_start_time, build_info.build_start_time)
     self.assertEqual(expected_chromium_revision, build_info.chromium_revision)
     self.assertEqual(expected_completed, build_info.completed)
     self.assertEqual(expected_result, build_info.result)
     self.assertEqual(expected_blame_list, build_info.blame_list)
     self.assertEqual(expected_failed_steps, build_info.failed_steps)
     self.assertEqual(expected_passed_steps, build_info.passed_steps)