Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149713006: [DevTools] Removed DOMAgent.getEventListenerForNode (Closed)

Created:
5 years, 7 months ago by kozy
Modified:
5 years, 7 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@extract-event-listeners-tree-outline
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Removed DOMAgent.getEventListenerForNode This methods was replaced with DOMDebugger.getEventListeners. BUG=469159 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195890

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -166 lines) Patch
M Source/core/inspector/InspectorDOMAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 4 chunks +0 lines, -46 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +0 lines, -92 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kozy
ptal
5 years, 7 months ago (2015-05-21 13:32:55 UTC) #1
yurys
https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (left): https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json#oldcode2350 Source/devtools/protocol.json:2350: { "name": "listeners", "type": "array", "items": { "$ref": "EventListener" ...
5 years, 7 months ago (2015-05-21 15:20:45 UTC) #3
kozy
https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (left): https://codereview.chromium.org/1149713006/diff/1/Source/devtools/protocol.json#oldcode2350 Source/devtools/protocol.json:2350: { "name": "listeners", "type": "array", "items": { "$ref": "EventListener" ...
5 years, 7 months ago (2015-05-22 10:57:21 UTC) #4
kozy
friendly ping.
5 years, 7 months ago (2015-05-25 18:22:44 UTC) #5
yurys
lgtm
5 years, 7 months ago (2015-05-26 04:23:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149713006/20001
5 years, 7 months ago (2015-05-26 05:02:46 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 06:12:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195890

Powered by Google App Engine
This is Rietveld 408576698