Adding heap-page statistics to blink-gc memory dump provider.

Source/platform/heap/Heap.h

Index: Source/platform/heap/Heap.h
diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h
index cee2a7dc2bb1ceee08699b6343bb5021e493d002..b17f72a9b2da241046257ac66bf83093b98f2a88 100644
--- a/Source/platform/heap/Heap.h
+++ b/Source/platform/heap/Heap.h
@@ -95,6 +95,7 @@ class FreePagePool;
 class NormalPageHeap;
 class OrphanedPagePool;
 class PageMemory;
+class WebProcessMemoryDump;
 
 #if ENABLE(GC_PROFILING)
 class TracedValue;
@@ -197,10 +198,8 @@ public:
     static const uint16_t magic = 0xfff1;
     static const uint16_t zappedMagic = 0x4321;
 
-#if ENABLE(GC_PROFILING)
-    NO_SANITIZE_ADDRESS
     size_t encodedSize() const { return m_encoded; }

[Primiano Tucci (use gerrit), 2015/05/28 12:47:00]

Any idea what is this?
P.S: what is NO_SANITIZE_ADDRESS and why did you remove it?

[Primiano Tucci (use gerrit), 2015/05/28 12:47:01]

We had a chat offline on this. I don't think you want to expose and dump this.
THis is a union of size() + other metadata.

[ssid, 2015/05/28 13:06:10]

Done.

-
+#if ENABLE(GC_PROFILING)
     NO_SANITIZE_ADDRESS
     size_t age() const { return m_age; }
 
@@ -399,6 +398,8 @@ public:
     // the stack.
     virtual void checkAndMarkPointer(Visitor*, Address) = 0;
     virtual void markOrphaned();
+
+    virtual void takeSnapshot(const String& dumpBaseName, size_t pageIndex) = 0;
 #if ENABLE(GC_PROFILING)
     virtual const GCInfo* findGCInfo(Address) = 0;
     virtual void snapshot(TracedValue*, ThreadState::SnapshotInfo*) = 0;
@@ -477,6 +478,8 @@ public:
 #endif
     virtual void checkAndMarkPointer(Visitor*, Address) override;
     virtual void markOrphaned() override;
+
+    void takeSnapshot(const String& dumpBaseName, size_t pageIndex) override;
 #if ENABLE(GC_PROFILING)
     const GCInfo* findGCInfo(Address) override;
     void snapshot(TracedValue*, ThreadState::SnapshotInfo*) override;
@@ -540,6 +543,7 @@ public:
     virtual void checkAndMarkPointer(Visitor*, Address) override;
     virtual void markOrphaned() override;
 
+    void takeSnapshot(const String& dumpBaseName, size_t pageIndex) override;
 #if ENABLE(GC_PROFILING)
     const GCInfo* findGCInfo(Address) override;
     void snapshot(TracedValue*, ThreadState::SnapshotInfo*) override;