Adding heap-page statistics to blink-gc memory dump provider.

Source/platform/heap/Heap.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 77 matching lines @@
 #else
 #define FILL_ZERO_IF_PRODUCTION(address, size) memset((address), 0, (size))
 #define FILL_ZERO_IF_NOT_PRODUCTION(address, size) do { } while (false)
 #endif
 
 class CallbackStack;
 class FreePagePool;
 class NormalPageHeap;
 class OrphanedPagePool;
 class PageMemory;
+class WebProcessMemoryDump;
 
 #if ENABLE(GC_PROFILING)
 class TracedValue;
 #endif
 
 // HeapObjectHeader is 4 byte (32 bit) that has the following layout:
 //
 // | gcInfoIndex (14 bit) | DOM mark bit (1 bit) | size (14 bit) | dead bit (1 bit) | freed bit (1 bit) | mark bit (1 bit) |
 //
 // - For non-large objects, 14 bit is enough for |size| because the blink
@@ skipping 82 matching lines @@
     // GC.
     void zapMagic();
 #endif
 
     void finalize(Address, size_t);
     static HeapObjectHeader* fromPayload(const void*);
 
     static const uint16_t magic = 0xfff1;
     static const uint16_t zappedMagic = 0x4321;
 
+    size_t encodedSize() const { return m_encoded; }

[Primiano Tucci (use gerrit), 2015/05/28 12:47:00]

Any idea what is this?
P.S: what is NO_SANITIZE_ADDRESS and why did you remove it?

[Primiano Tucci (use gerrit), 2015/05/28 12:47:01]

We had a chat offline on this. I don't think you want to expose and dump this.
THis is a union of size() + other metadata.

[ssid, 2015/05/28 13:06:10]

Done.

 #if ENABLE(GC_PROFILING)
     NO_SANITIZE_ADDRESS
-    size_t encodedSize() const { return m_encoded; }
-
-    NO_SANITIZE_ADDRESS
     size_t age() const { return m_age; }
 
     NO_SANITIZE_ADDRESS
     void incrementAge()
     {
         if (m_age < maxHeapObjectAge)
             m_age++;
     }
 #endif
 
@@ skipping 177 matching lines @@
     // Check if the given address points to an object in this
     // heap page. If so, find the start of that object and mark it
     // using the given Visitor. Otherwise do nothing. The pointer must
     // be within the same aligned blinkPageSize as the this-pointer.
     //
     // This is used during conservative stack scanning to
     // conservatively mark all objects that could be referenced from
     // the stack.
     virtual void checkAndMarkPointer(Visitor*, Address) = 0;
     virtual void markOrphaned();
+
+    virtual void takeSnapshot(const String& dumpBaseName, size_t pageIndex) = 0;
 #if ENABLE(GC_PROFILING)
     virtual const GCInfo* findGCInfo(Address) = 0;
     virtual void snapshot(TracedValue*, ThreadState::SnapshotInfo*) = 0;
     virtual void incrementMarkedObjectsAge() = 0;
     virtual void countMarkedObjects(ClassAgeCountsMap&) = 0;
     virtual void countObjectsToSweep(ClassAgeCountsMap&) = 0;
 #endif
 #if ENABLE(ASSERT) || ENABLE(GC_PROFILING)
     virtual bool contains(Address) = 0;
 #endif
@@ skipping 58 matching lines @@
     virtual size_t objectPayloadSizeForTesting() override;
     virtual bool isEmpty() override;
     virtual void removeFromHeap() override;
     virtual void sweep() override;
     virtual void markUnmarkedObjectsDead() override;
 #if defined(ADDRESS_SANITIZER)
     virtual void poisonUnmarkedObjects() override;
 #endif
     virtual void checkAndMarkPointer(Visitor*, Address) override;
     virtual void markOrphaned() override;
+
+    void takeSnapshot(const String& dumpBaseName, size_t pageIndex) override;
 #if ENABLE(GC_PROFILING)
     const GCInfo* findGCInfo(Address) override;
     void snapshot(TracedValue*, ThreadState::SnapshotInfo*) override;
     void incrementMarkedObjectsAge() override;
     void countMarkedObjects(ClassAgeCountsMap&) override;
     void countObjectsToSweep(ClassAgeCountsMap&) override;
 #endif
 #if ENABLE(ASSERT) || ENABLE(GC_PROFILING)
     // Returns true for the whole blinkPageSize page that the page is on, even
     // for the header, and the unmapped guard page at the start. That ensures
@@ skipping 43 matching lines @@
     virtual bool isEmpty() override;
     virtual void removeFromHeap() override;
     virtual void sweep() override;
     virtual void markUnmarkedObjectsDead() override;
 #if defined(ADDRESS_SANITIZER)
     virtual void poisonUnmarkedObjects() override;
 #endif
     virtual void checkAndMarkPointer(Visitor*, Address) override;
     virtual void markOrphaned() override;
 
+    void takeSnapshot(const String& dumpBaseName, size_t pageIndex) override;
 #if ENABLE(GC_PROFILING)
     const GCInfo* findGCInfo(Address) override;
     void snapshot(TracedValue*, ThreadState::SnapshotInfo*) override;
     void incrementMarkedObjectsAge() override;
     void countMarkedObjects(ClassAgeCountsMap&) override;
     void countObjectsToSweep(ClassAgeCountsMap&) override;
 #endif
 #if ENABLE(ASSERT) || ENABLE(GC_PROFILING)
     // Returns true for any address that is on one of the pages that this
     // large object uses. That ensures that we can use a negative result to
@@ skipping 743 matching lines @@
     size_t copySize = previousHeader->payloadSize();
     if (copySize > size)
         copySize = size;
     memcpy(address, previous, copySize);
     return address;
 }
 
 } // namespace blink
 
 #endif // Heap_h