Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1149663003: [turbofan] Don't mix up named/property accesses. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't mix up name/property accesses. R=mstarzinger@chromium.org Committed: https://crrev.com/5f11a5fa19bffc02ffcce9c06ae8953cba1b01b8 Cr-Commit-Position: refs/heads/master@{#28575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -78 lines) Patch
M src/compiler/js-generic-lowering.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/compiler/js-operator.h View 4 chunks +6 lines, -22 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 3 chunks +4 lines, -41 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-22 08:50:21 UTC) #1
Benedikt Meurer
Hey Michi, As discussed yesterday, remove the hackery around named/property access. Please take a look. ...
5 years, 7 months ago (2015-05-22 08:51:23 UTC) #2
Michael Starzinger
LGTM if Ben is fine with it.
5 years, 7 months ago (2015-05-22 09:02:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149663003/1
5 years, 7 months ago (2015-05-22 09:05:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 09:13:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5f11a5fa19bffc02ffcce9c06ae8953cba1b01b8 Cr-Commit-Position: refs/heads/master@{#28575}
5 years, 7 months ago (2015-05-22 09:13:51 UTC) #8
titzer
On 2015/05/22 09:13:51, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 7 months ago (2015-05-22 09:45:32 UTC) #9
Benedikt Meurer
5 years, 7 months ago (2015-05-22 10:49:36 UTC) #10
Message was sent while issue was closed.
On 2015/05/22 09:45:32, titzer wrote:
> On 2015/05/22 09:13:51, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/5f11a5fa19bffc02ffcce9c06ae8953cba1b01b8
> > Cr-Commit-Position: refs/heads/master@{#28575}
> 
> Yeah so this basically means that you cannot optimized
> LoadProperty/StoreProperty into LoadNamed/StoreNamed.

Well we can still optimize that, but we cannot mix up the operators.

Powered by Google App Engine
This is Rietveld 408576698