Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/compiler/js-operator.cc

Issue 1149663003: [turbofan] Don't mix up named/property accesses. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-operator.h ('k') | src/compiler/js-type-feedback.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-operator.h" 5 #include "src/compiler/js-operator.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/lazy-instance.h" 9 #include "src/base/lazy-instance.h"
10 #include "src/compiler/opcodes.h" 10 #include "src/compiler/opcodes.h"
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 return new (zone()) Operator1<int>( // -- 365 return new (zone()) Operator1<int>( // --
366 IrOpcode::kJSCallConstruct, Operator::kNoProperties, // opcode 366 IrOpcode::kJSCallConstruct, Operator::kNoProperties, // opcode
367 "JSCallConstruct", // name 367 "JSCallConstruct", // name
368 arguments, 1, 1, 1, 1, 2, // counts 368 arguments, 1, 1, 1, 1, 2, // counts
369 arguments); // parameter 369 arguments); // parameter
370 } 370 }
371 371
372 372
373 const Operator* JSOperatorBuilder::LoadNamed(const Unique<Name>& name, 373 const Operator* JSOperatorBuilder::LoadNamed(const Unique<Name>& name,
374 const VectorSlotPair& feedback, 374 const VectorSlotPair& feedback,
375 ContextualMode contextual_mode, 375 ContextualMode contextual_mode) {
376 PropertyICMode load_ic) { 376 LoadNamedParameters parameters(name, feedback, contextual_mode);
377 LoadNamedParameters parameters(name, feedback, contextual_mode, load_ic);
378 return new (zone()) Operator1<LoadNamedParameters>( // -- 377 return new (zone()) Operator1<LoadNamedParameters>( // --
379 IrOpcode::kJSLoadNamed, Operator::kNoProperties, // opcode 378 IrOpcode::kJSLoadNamed, Operator::kNoProperties, // opcode
380 "JSLoadNamed", // name 379 "JSLoadNamed", // name
381 1, 1, 1, 1, 1, 2, // counts 380 1, 1, 1, 1, 1, 2, // counts
382 parameters); // parameter 381 parameters); // parameter
383 } 382 }
384 383
385 384
386 const Operator* JSOperatorBuilder::LoadProperty( 385 const Operator* JSOperatorBuilder::LoadProperty(
387 const VectorSlotPair& feedback) { 386 const VectorSlotPair& feedback) {
388 LoadPropertyParameters parameters(feedback); 387 LoadPropertyParameters parameters(feedback);
389 return new (zone()) Operator1<LoadPropertyParameters>( // -- 388 return new (zone()) Operator1<LoadPropertyParameters>( // --
390 IrOpcode::kJSLoadProperty, Operator::kNoProperties, // opcode 389 IrOpcode::kJSLoadProperty, Operator::kNoProperties, // opcode
391 "JSLoadProperty", // name 390 "JSLoadProperty", // name
392 2, 1, 1, 1, 1, 2, // counts 391 2, 1, 1, 1, 1, 2, // counts
393 parameters); // parameter 392 parameters); // parameter
394 } 393 }
395 394
396 395
397 const Operator* JSOperatorBuilder::StoreNamed(LanguageMode language_mode, 396 const Operator* JSOperatorBuilder::StoreNamed(LanguageMode language_mode,
398 const Unique<Name>& name, 397 const Unique<Name>& name) {
399 PropertyICMode store_ic) { 398 StoreNamedParameters parameters(language_mode, name);
400 StoreNamedParameters parameters(language_mode, name, store_ic);
401 return new (zone()) Operator1<StoreNamedParameters>( // -- 399 return new (zone()) Operator1<StoreNamedParameters>( // --
402 IrOpcode::kJSStoreNamed, Operator::kNoProperties, // opcode 400 IrOpcode::kJSStoreNamed, Operator::kNoProperties, // opcode
403 "JSStoreNamed", // name 401 "JSStoreNamed", // name
404 2, 1, 1, 0, 1, 2, // counts 402 2, 1, 1, 0, 1, 2, // counts
405 parameters); // parameter 403 parameters); // parameter
406 } 404 }
407 405
408 406
409 const Operator* JSOperatorBuilder::DeleteProperty(LanguageMode language_mode) { 407 const Operator* JSOperatorBuilder::DeleteProperty(LanguageMode language_mode) {
410 return new (zone()) Operator1<LanguageMode>( // -- 408 return new (zone()) Operator1<LanguageMode>( // --
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 return new (zone()) Operator1<Unique<String>>( // -- 470 return new (zone()) Operator1<Unique<String>>( // --
473 IrOpcode::kJSCreateCatchContext, Operator::kNoProperties, // opcode 471 IrOpcode::kJSCreateCatchContext, Operator::kNoProperties, // opcode
474 "JSCreateCatchContext", // name 472 "JSCreateCatchContext", // name
475 2, 1, 1, 1, 1, 2, // counts 473 2, 1, 1, 1, 1, 2, // counts
476 name); // parameter 474 name); // parameter
477 } 475 }
478 476
479 } // namespace compiler 477 } // namespace compiler
480 } // namespace internal 478 } // namespace internal
481 } // namespace v8 479 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-operator.h ('k') | src/compiler/js-type-feedback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698