Lazy initialization for PushMessagingEventRouter

chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc

Index: chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc
diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..313445df92ccbcb8f1d77f787747a79ba84d5990
--- /dev/null
+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc
@@ -0,0 +1,47 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h"
+
+#include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
+#include "chrome/browser/extensions/extension_system_factory.h"
+#include "chrome/browser/profiles/profile_dependency_manager.h"
+
+namespace extensions {
+
+// static
+PushMessagingAPI* PushMessagingAPIFactory::GetForProfile(
+    Profile* profile) {
+  return static_cast<PushMessagingAPI*>(
+      GetInstance()->GetServiceForProfile(profile, true));
+}
+
+// static
+PushMessagingAPIFactory* PushMessagingAPIFactory::GetInstance() {
+  return Singleton<PushMessagingAPIFactory>::get();
+}
+
+PushMessagingAPIFactory::PushMessagingAPIFactory()
+    : ProfileKeyedServiceFactory("PushMessagingAPI",
+                                 ProfileDependencyManager::GetInstance()) {
+  DependsOn(extensions::ExtensionSystemFactory::GetInstance());

[Yoyo Zhou, 2012/12/10 20:06:01]

According to crbug.com/153827, this should also depend on ProfileSyncService.
That would cause this to be destroyed before ProfileSyncService, which should
fix that bug.

[akalin, 2012/12/10 20:37:12]

Cool, yeah, that should fix that bug.

[Joe Thomas, 2012/12/10 22:43:58]

Done.

+}
+
+PushMessagingAPIFactory::~PushMessagingAPIFactory() {
+}
+
+ProfileKeyedService* PushMessagingAPIFactory::BuildServiceInstanceFor(
+    Profile* profile) const {
+  return new PushMessagingAPI(profile);
+}
+
+bool PushMessagingAPIFactory::ServiceIsCreatedWithProfile() const {
+  return true;
+}
+
+bool PushMessagingAPIFactory::ServiceIsNULLWhileTesting() const {
+  return true;
+}
+
+}  // namespace extensions