chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h - Issue 11496004: Lazy initialization for PushMessagingEventRouter

Unified Diff: chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h

Issue 11496004: Lazy initialization for PushMessagingEventRouter (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/push_messaging/push_messaging_api.cc ('K') | « chrome/browser/extensions/api/push_messaging/push_messaging_api.cc ('k') | chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc » ('j') | chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h

diff --git a/chrome/browser/extensions/api/managed_mode/managed_mode_api_factory.h b/chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h

similarity index 51%

copy from chrome/browser/extensions/api/managed_mode/managed_mode_api_factory.h

copy to chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h

index e900b503b53a493841f433188b319ec13d7d74ad..cd6c522a18b4b0dbafdb69430ac9de8ef8cfd910 100644

--- a/chrome/browser/extensions/api/managed_mode/managed_mode_api_factory.h

+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_api_factory.h

@@ -2,24 +2,26 @@

// Use of this source code is governed by a BSD-style license that can be

akalin 2012/12/10 20:37:12 can you tweak the similarity settings to treat thi

Joe Thomas 2012/12/10 22:43:58 I tried with "git cl upload --similarity=100" but

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_EXTENSIONS_API_MANAGED_MODE_MANAGED_MODE_API_FACTORY_H_

-#define CHROME_BROWSER_EXTENSIONS_API_MANAGED_MODE_MANAGED_MODE_API_FACTORY_H_

+#ifndef CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_API_FACTORY_H_

+#define CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_API_FACTORY_H_

#include "base/memory/singleton.h"

#include "chrome/browser/profiles/profile_keyed_service_factory.h"

namespace extensions {

-class ManagedModeAPI;

+class PushMessagingAPI;

-class ManagedModeAPIFactory : public ProfileKeyedServiceFactory {

+class PushMessagingAPIFactory : public ProfileKeyedServiceFactory {

public:

- static ManagedModeAPIFactory* GetInstance();

+ static PushMessagingAPI* GetForProfile(Profile* profile);

+ static PushMessagingAPIFactory* GetInstance();

private:

- friend struct DefaultSingletonTraits<ManagedModeAPIFactory>;

+ friend struct DefaultSingletonTraits<PushMessagingAPIFactory>;

- ManagedModeAPIFactory();

- virtual ~ManagedModeAPIFactory();

+ PushMessagingAPIFactory();

+ virtual ~PushMessagingAPIFactory();

// ProfileKeyedServiceFactory implementation.

virtual ProfileKeyedService* BuildServiceInstanceFor(

@@ -30,4 +32,4 @@ class ManagedModeAPIFactory : public ProfileKeyedServiceFactory {

} // namespace extensions

-#endif // CHROME_BROWSER_EXTENSIONS_API_MANAGED_MODE_MANAGED_MODE_API_FACTORY_H_

+#endif // CHROME_BROWSER_EXTENSIONS_API_PUSH_MESSAGING_PUSH_MESSAGING_API_FACTORY_H_