Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1149563003: Make Touch.radiusX/Y float and make Touch.webkit* aliases in the IDL (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
mustaq, Rick Byers
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make Touch.radiusX/Y float and make Touch.webkit* aliases in the IDL BUG=460099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195637

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M Source/core/dom/Touch.h View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/core/dom/Touch.idl View 1 chunk +7 lines, -7 lines 2 comments Download
M Source/web/WebInputEventConversion.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
PTAL. This doesn't change any observable behavior, it just eliminates a few float->double->float conversions and ...
5 years, 7 months ago (2015-05-20 15:27:22 UTC) #2
Rick Byers
LGTM, thanks https://codereview.chromium.org/1149563003/diff/1/Source/core/dom/Touch.idl File Source/core/dom/Touch.idl (right): https://codereview.chromium.org/1149563003/diff/1/Source/core/dom/Touch.idl#newcode45 Source/core/dom/Touch.idl:45: // readonly attribute float rotationAngle; FYI I ...
5 years, 7 months ago (2015-05-20 15:33:41 UTC) #3
Rick Byers
You may want to mention BUG=460099 since it's really part of that larger issue.
5 years, 7 months ago (2015-05-20 15:34:06 UTC) #4
philipj_slow
https://codereview.chromium.org/1149563003/diff/1/Source/core/dom/Touch.idl File Source/core/dom/Touch.idl (right): https://codereview.chromium.org/1149563003/diff/1/Source/core/dom/Touch.idl#newcode45 Source/core/dom/Touch.idl:45: // readonly attribute float rotationAngle; On 2015/05/20 15:33:41, Rick ...
5 years, 7 months ago (2015-05-20 18:08:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149563003/1
5 years, 7 months ago (2015-05-20 18:09:08 UTC) #7
Rick Byers
On 2015/05/20 18:08:37, philipj_UTC2 wrote: > https://codereview.chromium.org/1149563003/diff/1/Source/core/dom/Touch.idl > File Source/core/dom/Touch.idl (right): > > https://codereview.chromium.org/1149563003/diff/1/Source/core/dom/Touch.idl#newcode45 > ...
5 years, 7 months ago (2015-05-20 18:59:48 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 20:32:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195637

Powered by Google App Engine
This is Rietveld 408576698