Source/core/dom/Touch.idl - Issue 1149563003: Make Touch.radiusX/Y float and make Touch.webkit* aliases in the IDL

Side by Side Diff: Source/core/dom/Touch.idl

Issue 1149563003: Make Touch.radiusX/Y float and make Touch.webkit* aliases in the IDL (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/dom/Touch.h ('k') | Source/web/WebInputEventConversion.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright 2008, The Android Open Source Project	2 * Copyright 2008, The Android Open Source Project

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * * Redistributions of source code must retain the above copyright	7 * * Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * * Redistributions in binary form must reproduce the above copyright	9 * * Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 22 matching lines...) Expand all Loading...
33 readonly attribute EventTarget target;	33 readonly attribute EventTarget target;

34 readonly attribute double screenX;	34 readonly attribute double screenX;

35 readonly attribute double screenY;	35 readonly attribute double screenY;

36 readonly attribute double clientX;	36 readonly attribute double clientX;

37 readonly attribute double clientY;	37 readonly attribute double clientY;

38 readonly attribute double pageX;	38 readonly attribute double pageX;

39 readonly attribute double pageY;	39 readonly attribute double pageY;

40	40

41 // Touch Events Extensions	41 // Touch Events Extensions

42 // http://rawgit.com/w3c/touch-events/master/touchevents.html#touch-interfac e	42 // http://rawgit.com/w3c/touch-events/master/touchevents.html#touch-interfac e

43 // FIXME: radiusX and radiusY should be float, not double.	43 readonly attribute float radiusX;

44 readonly attribute double radiusX;	44 readonly attribute float radiusY;

45 readonly attribute double radiusY;	45 // readonly attribute float rotationAngle;
	Rick Byers 2015/05/20 15:33:41 FYI I think we can unprefixing this too and deprec FYI I think we can unprefixing this too and deprecated all the prefix versions - see crbug.com/460099. philipj_slow 2015/05/20 18:08:37 That looks very quick to do indeed, and I'd be ver Show quoted text On 2015/05/20 15:33:41, Rick Byers wrote: > FYI I think we can unprefixing this too and deprecated all the prefix versions - > see crbug.com/460099. That looks very quick to do indeed, and I'd be very quick to LGTM both shipping rotationAngle and deprecating the prefixed attributes :)
46 readonly attribute float force;	46 readonly attribute float force;

47	47

48 // Non-standard APIs	48 // Non-standard APIs

49 [MeasureAs=PrefixedTouchRadiusX] readonly attribute double webkitRadiusX;	49 [MeasureAs=PrefixedTouchRadiusX, ImplementedAs=radiusX] readonly attribute f loat webkitRadiusX;

50 [MeasureAs=PrefixedTouchRadiusY] readonly attribute double webkitRadiusY;	50 [MeasureAs=PrefixedTouchRadiusY, ImplementedAs=radiusY] readonly attribute f loat webkitRadiusY;

51 [MeasureAs=PrefixedTouchRotationAngle] readonly attribute float webkitRotati onAngle;	51 [MeasureAs=PrefixedTouchRotationAngle, ImplementedAs=rotationAngle] readonly attribute float webkitRotationAngle;

52 [MeasureAs=PrefixedTouchForce] readonly attribute float webkitForce;	52 [MeasureAs=PrefixedTouchForce, ImplementedAs=force] readonly attribute float webkitForce;

53 };	53 };

OLD	NEW