Issue 114943004: Reland "Handlify concat string and substring."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114943004: Reland "Handlify concat string and substring." (Closed)

Created:
7 years ago by Yang

Modified:
7 years ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland "Handlify concat string and substring." This relands commit r17490. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18408

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -338 lines)			Patch
M	src/factory.h	View		1 chunk	+12 lines, -7 lines	0 comments	Download
M	src/factory.cc	View		3 chunks	+205 lines, -13 lines	0 comments	Download
M	src/handles.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+0 lines, -258 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View		4 chunks	+17 lines, -15 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	3 chunks	+8 lines, -10 lines	0 comments	Download
M	test/mjsunit/string-slices.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Yang

Patch set 1 is the original CL. Patch set 2 is the fix that preserves ...

7 years ago (2013-12-17 11:25:36 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r18408 (presubmit successful).