src/objects.cc - Issue 114943004: Reland "Handlify concat string and substring."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 114943004: Reland "Handlify concat string and substring." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix test case. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index bfe1f5577833c9902afa27efeab45953436bb53c..57e71a56dc75db030c4dd6d975737aa9f9251014 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -9298,14 +9298,6 @@ uint32_t StringHasher::ComputeUtf8Hash(Vector<const char> chars,

}

-MaybeObject* String::SubString(int start, int end, PretenureFlag pretenure) {

- Heap* heap = GetHeap();

- if (start == 0 && end == length()) return this;

- MaybeObject* result = heap->AllocateSubString(this, start, end, pretenure);

- return result;

void String::PrintOn(FILE* file) {

int length = this->length();

for (int i = 0; i < length; i++) {

« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »