Clean up unit munging unit tests using common NaCl API.

Clean up unit munging unit tests using common NaCl API.

Simplify the munging unit tests to follow the new NaCl utilities
for munging tests.

Note that this CL takes advantage of changes added by
CL https://codereview.chromium.org/1140153004

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cbb1d3d73045a8c2a91d0c66c438fd5d8cdd9473

[Karl, 2015-06-04 20:31:56]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-06-04 22:20:57]

LGTM.

I assume there is a matching LLVM CL that this needs to be atomically landed
with?  Can you point to that CL in the description?  (and vice versa,
presumably)

https://codereview.chromium.org/1149423011/diff/1/unittest/BitcodeMunge.cpp
File unittest/BitcodeMunge.cpp (right):

https://codereview.chromium.org/1149423011/diff/1/unittest/BitcodeMunge.cpp#n...
unittest/BitcodeMunge.cpp:42: Translator.translateBuffer("Test",
MungedInput.get());
Maybe "document" the constant string argument using something like:
  const char *TestName = "Test";

https://codereview.chromium.org/1149423011/diff/1/unittest/IceParseInstsTest.cpp
File unittest/IceParseInstsTest.cpp (right):

https://codereview.chromium.org/1149423011/diff/1/unittest/IceParseInstsTest....
unittest/IceParseInstsTest.cpp:339: 
This new blank line seems out of character. :)

[Karl, 2015-06-08 16:25:21]

Committed patchset #2 (id:20001) manually as
cbb1d3d73045a8c2a91d0c66c438fd5d8cdd9473 (tree was closed).

[Karl, 2015-06-08 16:25:40]

https://codereview.chromium.org/1149423011/diff/1/unittest/BitcodeMunge.cpp
File unittest/BitcodeMunge.cpp (right):

https://codereview.chromium.org/1149423011/diff/1/unittest/BitcodeMunge.cpp#n...
unittest/BitcodeMunge.cpp:42: Translator.translateBuffer("Test",
MungedInput.get());
On 2015/06/04 22:20:57, stichnot wrote:
> Maybe "document" the constant string argument using something like:
>   const char *TestName = "Test";

Done.

https://codereview.chromium.org/1149423011/diff/1/unittest/IceParseInstsTest.cpp
File unittest/IceParseInstsTest.cpp (right):

https://codereview.chromium.org/1149423011/diff/1/unittest/IceParseInstsTest....
unittest/IceParseInstsTest.cpp:339: 
On 2015/06/04 22:20:57, stichnot wrote:
> This new blank line seems out of character. :)

Done.