Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140153004: Clean up bitcode munging tests. (Closed)

Created:
5 years, 7 months ago by Karl
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up bitcode munging tests. Cleans up bitcode munging tests in several ways: 1) Extracts out common definitions into a single header file. 2) Puts all test/code for munging in same namespace. 3) Removes test name argument from calls to runTest. 4) Uses ARRAY and ARRAY_TERM macros to pass array arguments to bitcode munger constructors and runTest calls. BUG=None R=jvoung@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/fe3e97184569a29f07584c23fa3d996754aa5311

Patch Set 1 #

Patch Set 2 : Fix more callers to runTest. #

Total comments: 6

Patch Set 3 : Fix issues in patch set 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -540 lines) Patch
M include/llvm/Bitcode/NaCl/NaClBitcodeMunge.h View 6 chunks +46 lines, -59 lines 0 comments Download
M lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp View 7 chunks +14 lines, -19 lines 0 comments Download
M unittests/Bitcode/NaClCompressTests.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
A unittests/Bitcode/NaClMungeTest.h View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M unittests/Bitcode/NaClMungeWriteErrorTests.cpp View 18 chunks +43 lines, -55 lines 0 comments Download
M unittests/Bitcode/NaClMungedBitcodeTest.cpp View 38 chunks +39 lines, -56 lines 0 comments Download
M unittests/Bitcode/NaClMungedIoTest.cpp View 5 chunks +7 lines, -22 lines 0 comments Download
M unittests/Bitcode/NaClObjDumpTypesTest.cpp View 80 chunks +105 lines, -213 lines 0 comments Download
M unittests/Bitcode/NaClParseInstsTest.cpp View 19 chunks +45 lines, -81 lines 0 comments Download
M unittests/Bitcode/NaClParseTypesTest.cpp View 1 4 chunks +9 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
5 years, 7 months ago (2015-05-14 20:12:47 UTC) #2
jvoung (off chromium)
LGTM thanks https://codereview.chromium.org/1140153004/diff/20001/unittests/Bitcode/NaClMungeTest.h File unittests/Bitcode/NaClMungeTest.h (right): https://codereview.chromium.org/1140153004/diff/20001/unittests/Bitcode/NaClMungeTest.h#newcode1 unittests/Bitcode/NaClMungeTest.h:1: //===- llvm/unittest/Bitcode/NaClMungeUtils.h - Test munging utils --------===// ...
5 years, 7 months ago (2015-05-14 22:58:39 UTC) #3
Karl
Committed patchset #3 (id:40001) manually as fe3e97184569a29f07584c23fa3d996754aa5311 (presubmit successful).
5 years, 7 months ago (2015-05-15 15:56:36 UTC) #4
Karl
5 years, 7 months ago (2015-05-18 16:02:38 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1140153004/diff/20001/unittests/Bitcode/NaClM...
File unittests/Bitcode/NaClMungeTest.h (right):

https://codereview.chromium.org/1140153004/diff/20001/unittests/Bitcode/NaClM...
unittests/Bitcode/NaClMungeTest.h:1: //===-
llvm/unittest/Bitcode/NaClMungeUtils.h - Test munging utils --------===//
On 2015/05/14 22:58:39, jvoung wrote:
> NaClMungeUtils.h
> ->
> NaClMungeTest.h

Done.

https://codereview.chromium.org/1140153004/diff/20001/unittests/Bitcode/NaClM...
unittests/Bitcode/NaClMungeTest.h:12: #ifndef
LLVM_UNITTEST_BITCODE_NACLMUNGEUTILS_H
On 2015/05/14 22:58:39, jvoung wrote:
> NACLMUNGEUTILS
> ->
> NACLMUNGETEST

Done.

https://codereview.chromium.org/1140153004/diff/20001/unittests/Bitcode/NaClM...
unittests/Bitcode/NaClMungeTest.h:41: #endif // end
LLVM_UNITTEST_BITCODE_NACLMUNGEUTILS_H
On 2015/05/14 22:58:39, jvoung wrote:
> same

Done.

Powered by Google App Engine
This is Rietveld 408576698