tests/compiler/dart2js/semantic_visitor_test_send_data.dart - Issue 1149403009: Refactoring resolution of local access and unqualified access of statics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/semantic_visitor_test_send_data.dart

Issue 1149403009: Refactoring resolution of local access and unqualified access of statics (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/resolution/members.dart ('K') | « tests/compiler/dart2js/semantic_visitor_test.dart ('k') | tests/compiler/dart2js/simple_inferrer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/semantic_visitor_test_send_data.dart

diff --git a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart

index e99f58b3257cb49d27e8e0bb8c9a83098ab87bce..c392d1030f202e0ab20ac63d3775f0848ffb23c8 100644

--- a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart

+++ b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart

@@ -350,8 +350,9 @@ const Map<String, List<Test>> SEND_TESTS = const {

m() => o;

}

''',

- const Visit(VisitKind.VISIT_UNRESOLVED_GET,

- name: 'o')),

+ const Visit(VisitKind.VISIT_STATIC_SETTER_GET,

+ element: 'setter(C#o)')),

const Test.clazz(

'''

class C {

@@ -462,8 +463,8 @@ const Map<String, List<Test>> SEND_TESTS = const {

m() { o(null, 42); }

}

''',

- const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,

- name: 'o',

+ const Visit(VisitKind.VISIT_STATIC_SETTER_INVOKE,

+ element: 'setter(C#o)',

arguments: '(null,42)')),

const Test.clazz(

'''

@@ -720,8 +721,8 @@ const Map<String, List<Test>> SEND_TESTS = const {

set o(_) {}

m() => o;

''',

- const Visit(VisitKind.VISIT_UNRESOLVED_GET,

- name: 'o')),

+ const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_GET,

+ element: 'setter(o)')),

const Test.prefix(

'''

set o(_) {}

@@ -786,8 +787,8 @@ const Map<String, List<Test>> SEND_TESTS = const {

set o(_) {}

m() => o(null, 42);

''',

- const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,

- name: 'o',

+ const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,

+ element: 'setter(o)',

arguments: '(null,42)')),

const Test.prefix(

'''