tests/compiler/dart2js/semantic_visitor_test.dart - Issue 1149403009: Refactoring resolution of local access and unqualified access of statics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/semantic_visitor_test.dart

Issue 1149403009: Refactoring resolution of local access and unqualified access of statics (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/resolution/members.dart ('K') | « tests/compiler/dart2js/resolver_test.dart ('k') | tests/compiler/dart2js/semantic_visitor_test_send_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/semantic_visitor_test.dart

diff --git a/tests/compiler/dart2js/semantic_visitor_test.dart b/tests/compiler/dart2js/semantic_visitor_test.dart

index 21ab642e03aacedd575ae908730459c1355cc434..c8c2a513e42fbbb382b711373d7f766ddaea0ba9 100644

--- a/tests/compiler/dart2js/semantic_visitor_test.dart

+++ b/tests/compiler/dart2js/semantic_visitor_test.dart

@@ -184,11 +184,6 @@ const List<VisitKind> UNTESTABLE_KINDS = const <VisitKind>[

VisitKind.VISIT_SUPER_METHOD_SETTER_COMPOUND,

VisitKind.VISIT_SUPER_METHOD_SETTER_PREFIX,

VisitKind.VISIT_SUPER_METHOD_SETTER_POSTFIX,

- // Invalid use of setters is currently reported through an erroneous element.

- VisitKind.VISIT_STATIC_SETTER_INVOKE,

- VisitKind.VISIT_STATIC_SETTER_GET,

- VisitKind.VISIT_TOP_LEVEL_SETTER_GET,

- VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,

// The constant expressions of assignment to constant type literals cannot be

// handled the compile constant evaluator.

VisitKind.VISIT_CLASS_TYPE_LITERAL_SET,