Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1149383006: Move smart deploy to tristate. (Closed)

Created:
5 years, 6 months ago by rsadam
Modified:
5 years, 6 months ago
Reviewers:
Mark P, bshe, sky
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move smart deploy to tristate. BUG= Committed: https://crrev.com/318530d771586b39056c0da7b8bdad03469a0dc4 Cr-Commit-Position: refs/heads/master@{#333058}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Change histogram id. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M ash/virtual_keyboard_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 3 chunks +17 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_switches.h View 1 1 chunk +9 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_switches.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
rsadam
Hi Biao, PTAL!
5 years, 6 months ago (2015-06-04 18:11:12 UTC) #2
rsadam
5 years, 6 months ago (2015-06-04 18:13:58 UTC) #3
bshe
On 2015/06/04 18:13:58, rsadam wrote: looks like some tests are failing. Otherwise, looks good to ...
5 years, 6 months ago (2015-06-04 21:20:37 UTC) #4
rsadam
+mpearson for histograms.xml OWNERS +sky@ for ash/* OWNERS
5 years, 6 months ago (2015-06-04 22:09:27 UTC) #6
sky
LGTM
5 years, 6 months ago (2015-06-04 22:55:24 UTC) #7
Mark P
histograms.xml lgtm
5 years, 6 months ago (2015-06-04 23:03:38 UTC) #8
rsadam
@bshe: I don't think codereview is smart enough to pick up looks good to me ...
5 years, 6 months ago (2015-06-05 14:34:09 UTC) #9
bshe
On 2015/06/05 14:34:09, rsadam wrote: > @bshe: I don't think codereview is smart enough to ...
5 years, 6 months ago (2015-06-05 14:36:21 UTC) #11
rsadam
On 2015/06/05 14:36:21, bshe wrote: > On 2015/06/05 14:34:09, rsadam wrote: > > @bshe: I ...
5 years, 6 months ago (2015-06-05 14:45:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149383006/60001
5 years, 6 months ago (2015-06-05 14:46:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/32030)
5 years, 6 months ago (2015-06-05 14:54:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149383006/60001
5 years, 6 months ago (2015-06-05 15:26:39 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-05 15:57:12 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:58:02 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/318530d771586b39056c0da7b8bdad03469a0dc4
Cr-Commit-Position: refs/heads/master@{#333058}

Powered by Google App Engine
This is Rietveld 408576698