Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/about_flags.cc

Issue 1149383006: Move smart deploy to tristate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change histogram id. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 73103c715b8157cb7c8492125309d334a1f36479..5abc8a0b9f3ea5f915ce6cb3c1bf930086d39304 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -453,6 +453,16 @@ const Experiment::Choice kFloatingVirtualKeyboardChoices[] = {
keyboard::switches::kFloatingVirtualKeyboardEnabled},
};
+const Experiment::Choice kSmartVirtualKeyboardChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ keyboard::switches::kSmartVirtualKeyboard,
+ keyboard::switches::kSmartVirtualKeyboardDisabled},
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ keyboard::switches::kSmartVirtualKeyboard,
+ keyboard::switches::kSmartVirtualKeyboardEnabled},
+};
+
const Experiment::Choice kGestureTypingChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
@@ -1426,6 +1436,13 @@ const Experiment kExperiments[] = {
MULTI_VALUE_TYPE(kFloatingVirtualKeyboardChoices)
},
{
+ "smart-virtual-keyboard",
+ IDS_FLAGS_SMART_VIRTUAL_KEYBOARD_NAME,
+ IDS_FLAGS_SMART_VIRTUAL_KEYBOARD_DESCRIPTION,
+ kOsCrOS,
+ MULTI_VALUE_TYPE(kSmartVirtualKeyboardChoices)
+ },
+ {
"gesture-typing",
IDS_FLAGS_GESTURE_TYPING_NAME,
IDS_FLAGS_GESTURE_TYPING_DESCRIPTION,
@@ -1439,13 +1456,6 @@ const Experiment kExperiments[] = {
kOsCrOS,
MULTI_VALUE_TYPE(kGestureEditingChoices)
},
- {
- "disable-smart-virtual-keyboard",
- IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_NAME,
- IDS_FLAGS_DISABLE_SMART_VIRTUAL_KEYBOARD_DESCRIPTION,
- kOsCrOS,
- SINGLE_VALUE_TYPE(keyboard::switches::kDisableSmartVirtualKeyboard)
- },
#endif
{
"enable-simple-cache-backend",
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698