Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1149303002: Add a dirty bit for updateDescendantDependentFlags. (Closed)

Created:
5 years, 7 months ago by esprehn
Modified:
5 years, 7 months ago
Reviewers:
chrishtr, ojan
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a dirty bit for updateDescendantDependentFlags. We're walking the entire layer tree every frame even if there's no work to do inside updateDescendantDependentFlagsForEntireSubtree. This patch adds a bit to avoid doing that tree walk. BUG=490921 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195759

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : try again. #

Patch Set 4 : try again. #

Patch Set 5 : try again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 2 3 4 3 chunks +23 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 2 3 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149303002/80001
5 years, 7 months ago (2015-05-21 23:17:00 UTC) #2
esprehn
5 years, 7 months ago (2015-05-22 00:38:17 UTC) #4
chrishtr
lgtm
5 years, 7 months ago (2015-05-22 00:57:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149303002/80001
5 years, 7 months ago (2015-05-22 01:04:01 UTC) #8
esprehn
5 years, 7 months ago (2015-05-22 05:12:57 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 195759 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698